Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MD] Change cluster selector component name to data source selector #6042

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

BionIT
Copy link
Collaborator

@BionIT BionIT commented Mar 5, 2024

Description

This change renames clusterselector to datasource selector

Issues Resolved

Fixes #6038

Screenshot

rename.mp4

Testing the changes

The following steps were performed in the recording above:

  1. enable data source plugin
  2. add sample data should render data source selector correctly and can select data source and add sample data, and sample data should render correctly
  3. in dev tools, select a data source and perform query should render results correctly
  4. go to query workbench, should render data source selector correctly and can select data source and request to yield indices
  5. go to alert plugin, should render data source selector correctly and can select data source and request to yield monitors from data source

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@BionIT BionIT changed the title change component name Change cluster selector component to data source selector Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.13%. Comparing base (70adcc9) to head (9d2ae45).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6042      +/-   ##
==========================================
- Coverage   67.13%   67.13%   -0.01%     
==========================================
  Files        3318     3318              
  Lines       64021    64021              
  Branches    10256    10256              
==========================================
- Hits        42981    42979       -2     
- Misses      18548    18549       +1     
- Partials     2492     2493       +1     
Flag Coverage Δ
Linux_1 31.63% <ø> (ø)
Linux_2 55.20% <ø> (ø)
Linux_3 44.59% <100.00%> (+<0.01%) ⬆️
Linux_4 35.16% <20.00%> (ø)
Windows_1 31.65% <ø> (ø)
Windows_2 55.17% <ø> (ø)
Windows_3 44.60% <100.00%> (ø)
Windows_4 35.16% <20.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BionIT BionIT changed the title Change cluster selector component to data source selector [MD] Change cluster selector component name to data source selector Mar 5, 2024
Signed-off-by: Lu Yu <[email protected]>
@BionIT BionIT added v2.13.0 backport 2.x multiple datasource multiple datasource project labels Mar 6, 2024
Copy link
Member

@seraphjiang seraphjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks

@ashwin-pc
Copy link
Member

Isnt Data Connection what we aligned on for the name here? #5790 (comment)

@BionIT
Copy link
Collaborator Author

BionIT commented Mar 6, 2024

Isnt Data Connection what we aligned on for the name here? #5790 (comment)

@ashwin-pc This is the current proposal #6039

@ashwin-pc
Copy link
Member

ashwin-pc commented Mar 6, 2024

That issue was opened 5 hours ago though. Let me take the conversation there. Can we give people time to respond to the proposal?

@seraphjiang
Copy link
Member

That issue was opened 5 hours ago though. Let me take the conversation there. Can we give people time to respond to the proposal?

Thanks @ashwin-pc replied in rfc,

It is expecting to disambious this in 2.13 for developer. It makes sense to give people time for feedback.

@@ -1,11 +0,0 @@
/*
Copy link
Member

@Flyingliuhub Flyingliuhub Mar 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to remove folder as well? the folder name still using the cluster_selector?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, the folder has been removed

@BionIT BionIT merged commit 8839256 into opensearch-project:main Mar 6, 2024
67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 6, 2024
…6042)

* change component name

Signed-off-by: Lu Yu <[email protected]>

* add change log

Signed-off-by: Lu Yu <[email protected]>

---------

Signed-off-by: Lu Yu <[email protected]>
(cherry picked from commit 8839256)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
BionIT pushed a commit that referenced this pull request Mar 7, 2024
…6042) (#6054)

* change component name



* add change log



---------


(cherry picked from commit 8839256)

Signed-off-by: Lu Yu <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MD] Change name of data source picker from cluster selector
7 participants